Skip to content

Revamp exception descriptions #80

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Nov 15, 2024
Merged

Conversation

kgodlewski
Copy link
Contributor

What this PR does:

  • make the descriptions less cluttered by removing nonessential information
  • rename "fields" to attributes in exception messages

What it does not do:

  • remove exceptions that the user should not care about
  • rename Field to Attribute in exception class names. If we agree on the message, we can rename the exception classes accordingly.

Co-authored-by: Sabine Ståhlberg <sabine.stahlberg@neptune.ai>
@kgodlewski kgodlewski requested a review from normandy7 November 15, 2024 09:37
@kgodlewski kgodlewski merged commit 7a1469c into main Nov 15, 2024
4 checks passed
@kgodlewski kgodlewski deleted the kg/revamp-exception-messages branch November 15, 2024 10:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants