Convert naive datetime objects to UTC
#68
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is to be more consistent with other spots
Any `datetime` object passed to `log*` functions will be converted to UTC prior to logging. If `tzinfo` is not provided, it is assumed to be in local time.
kgodlewski
force-pushed
the
kg/handle-naive-timestamps
branch
from
7587969 to
106475d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Assume that if
tzinfois not provided, thedatetimeobject is in local timezone, and convert it to UTC.Previously we would log
datetimesas local timestamp, which resulted in incorrect data.