Change the logger's configuration to be more resilient #66
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Use `QueueHandler` in child processes, paired with `QueueListener` in the main process * Make sure initializing multiple Runs in a single process does not break the logger * Make sure importing other neptune libs (like neptune-fetcher) does not break logging
kgodlewski
changed the title
PatrykGala
approved these changes
Oct 31, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously we configured loggers separately in multiple processes. This caused problems with logging to files and exceptions about closed filedescriptors appearing randomly from time to time.
The core part is having separate initialization methods for main and child processes, and passing a shared
multiprocessing.Queue, which is used for logging, toSyncProcess.Summary of the changes:
QueueHandlerin child processes, paired withQueueListenerin the main process