Skip to content

Check if SyncProcess is alive in SIGCHLD handler. #56

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 17, 2024
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions src/neptune_scale/__init__.py
Original file line number Diff line number Diff line change
Expand Up @@ -273,6 +273,10 @@ def __init__(
self.wait_for_processing(verbose=False)

def _handle_signal(self, signum: int, frame: Any) -> None:
# We should not be concerned about SIGCHLD if it's not about our child process
if signum == signal.SIGCHLD and self._sync_process.is_alive():
return

if not self._is_closing:
signame = safe_signal_name(signum)
logger.debug(f"Received signal {signame}. Terminating.")
Expand Down
Loading