Remove iterables from log_config value type hints
#53
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SiddhantSadangi
added
the
documentation
michalsosn
reviewed
Oct 15, 2024
michalsosn
approved these changes
Oct 15, 2024
michalsosn
approved these changes
Oct 15, 2024
SiddhantSadangi
added a commit
that referenced
this pull request
Oct 31, 2024
This reverts commit 0988dff.
SiddhantSadangi
added a commit
that referenced
this pull request
Nov 5, 2024
…upport for tags (#67) * Revert "Remove iterables from `log_config` value type hints (#53)" This reverts commit 0988dff. * Enhance value serialization to convert non-string list elements to strings and expand log_configs tests for various data types * Added tuple support * Add tuple support to log_configs and metadata fields; update tests for tag handling * Added `tuple` to `add_tags()` and `remove_tags()` typehints * Updated readme * Applied PR review suggestions * Merge commit '85bb57efbe10ad5eec4caa74ff3a6b33ca4f626c' into ss/log_configs_series_support * Revert "Merge commit '85bb57efbe10ad5eec4caa74ff3a6b33ca4f626c' into ss/log_configs_series_support" This reverts commit 2f2226d.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.