Skip to content

fix: extract released version from the gha env variable #273

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 18, 2025

Conversation

michalsosn
Copy link
Contributor

@michalsosn michalsosn commented Jun 17, 2025

fixes PY-134

Summary by Sourcery

Fix version extraction in the release workflow to ensure the correct version is passed to Poetry dynamic versioning.

Bug Fixes:

  • Extract the released version from the GitHub ref and apply it as a bypass for poetry-dynamic-versioning during the build step.

CI:

  • Add a step in the release workflow to derive the tag name into a VERSION variable and set POETRY_DYNAMIC_VERSIONING_BYPASS before building the package.

Copy link

linear bot commented Jun 17, 2025

Copy link

sourcery-ai bot commented Jun 17, 2025

Reviewer's Guide

Updated the release workflow to extract the version from the GitHub Actions ref and pass it to Poetry Dynamic Versioning via a bypass environment variable, replacing the direct 'poetry build' call.

File-Level Changes

Change Details Files
Extract release version from GHA ref and set bypass for poetry-dynamic-versioning.
  • Replaced single-line 'poetry build' with a multi-line bash block.
  • Parsed the tag name from 'github.ref' using sed into VERSION.
  • Echoed the extracted VERSION for logging clarity.
  • Assigned POETRY_DYNAMIC_VERSIONING_BYPASS to the extracted VERSION in the build command.
.github/workflows/release.yml

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

Copy link

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @michalsosn - I've reviewed your changes and they look great!


Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

@michalsosn michalsosn added this pull request to the merge queue Jun 18, 2025
Merged via the queue into main with commit bc2277d Jun 18, 2025
22 checks passed
@michalsosn michalsosn deleted the ms/versioning-bypass branch June 18, 2025 18:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants