Skip to content

restore patch on SpawnProcess.terminate #269

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 7 commits into from

Conversation

michalsosn
Copy link
Contributor

@michalsosn michalsosn commented Jun 12, 2025

Summary by Sourcery

Update end-to-end sync tests to reintroduce the SpawnProcess termination hack and expand test data with additional config logs

Tests:

  • Re-add multiprocessing.context.SpawnProcess.terminate to the hung_method parameters in test_sync_stop_timeout
  • Log integer and float config values in test_sync_stop_timeout to increase data coverage

Copy link

sourcery-ai bot commented Jun 12, 2025

Reviewer's Guide

Re-enable the SpawnProcess.terminate patch in the E2E sync tests and extend test coverage by logging additional config data types.

File-Level Changes

Change Details Files
Restore patch on SpawnProcess.terminate in test parameterization
  • Insert 'multiprocessing.context.SpawnProcess.terminate' into the hung_method param list
tests/e2e/test_sync.py
Extend test to log additional config data types
  • Add run.log_configs with an integer value
  • Add run.log_configs with a float value
tests/e2e/test_sync.py

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

@michalsosn michalsosn force-pushed the ms/bool-wait-2 branch 3 times, most recently from 7b097eb to 2f21eee Compare June 12, 2025 14:42
Michał Sośnicki added 2 commits June 12, 2025 17:44
@michalsosn michalsosn closed this Jun 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant