Sending operations asynchronously #17
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Raalsky
commented
Aug 19, 2024
normandy7
reviewed
Aug 19, 2024
normandy7
previously requested changes
Aug 19, 2024
Raalsky
force-pushed
the
rj/basic-submission-flow
branch
2 times, most recently
from
c1fda0b to
16294ab
Compare
szysad
reviewed
Aug 19, 2024
Raalsky
commented
Aug 20, 2024
kgodlewski
reviewed
Aug 20, 2024
| _, alive = psutil.wait_procs(children, timeout=KILL_TIMEOUT) | ||
| for child_proc in alive: | ||
| _kill(child_proc) | ||
| # finish with terminating self |
There was a problem hiding this comment.
sys.exit() would work as well
There was a problem hiding this comment.
Actuall I would use os.killpg using the parent's process group ID. This will kill all children processes on OS level
There was a problem hiding this comment.
os.killpg is not available on Windows, sys.exit() will just "close" the process, instead we would like to allow script to gentle handle the KeyboardInterrupt and clean some stuff.
|
|
||
| class QueueElement(NamedTuple): | ||
| sequence_id: int | ||
| occured_at: float |
There was a problem hiding this comment.
How about renaming this field to timestamp?
kgodlewski
reviewed
Aug 20, 2024
normandy7
reviewed
Aug 21, 2024
| if len(serialized_operation) > MAX_QUEUE_ELEMENT_SIZE: | ||
| raise ValueError(f"Operation size exceeds the maximum allowed size ({MAX_QUEUE_ELEMENT_SIZE})") | ||
| if len(serialized_operation) > MAX_QUEUE_ELEMENT_SIZE: | ||
| raise ValueError(f"Operation size exceeds the maximum allowed size ({MAX_QUEUE_ELEMENT_SIZE})") |
There was a problem hiding this comment.
"Operation size" sounds a bit strange.
Suggested change
| raise ValueError(f"Operation size exceeds the maximum allowed size ({MAX_QUEUE_ELEMENT_SIZE})") | |
| raise ValueError(f"The number of queued operations exceeds the maximum allowed size ({MAX_QUEUE_ELEMENT_SIZE})") |
?
There was a problem hiding this comment.
It's not the number of operations and this probably will never be raised
Co-authored-by: Sabine <sabine.nyholm@neptune.ai>
Co-authored-by: Sabine <sabine.nyholm@neptune.ai>
Co-authored-by: Sabine <sabine.nyholm@neptune.ai>
Co-authored-by: Sabine <sabine.nyholm@neptune.ai>
Co-authored-by: Sabine <sabine.nyholm@neptune.ai>
Co-authored-by: Sabine <sabine.nyholm@neptune.ai>
Co-authored-by: Sabine <sabine.nyholm@neptune.ai>
Co-authored-by: Sabine <sabine.nyholm@neptune.ai>
Raalsky
force-pushed
the
rj/basic-submission-flow
branch
from
a89c60f to
e9659f3
Compare
kgodlewski
approved these changes
Aug 21, 2024
Raalsky
dismissed
normandy7’s stale review
Easier to get it working on main in separate PR
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.