-
Notifications
You must be signed in to change notification settings - Fork 1
feature: Implement saving operations to / reading from the on-disk storage #149
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 2 commits
Commits
Show all changes
12 commits
Select commit
Hold shift + click to select a range
a882291
feat: persistent mode
PatrykGala 07ff04d
feat: rebase
PatrykGala 0e9eead
feat: fix tests - remove SyncRun
PatrykGala d7cbf7f
feat: Review changes
PatrykGala dcc80aa
feat: Review changes
PatrykGala 49f6dcb
feat: Review changes
PatrykGala e1b6b37
feat: Add tests for sync process
PatrykGala 89d7fc3
feat: Revert elseif
PatrykGala bb1cd6b
feat: ValueError -> RuntimeError
PatrykGala f3313ea
feat: Add exceptions
PatrykGala 82a85ba
feat: Add exceptions - precommit
PatrykGala 8bee433
feat: Extract _validate_existing_db
PatrykGala File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -2,6 +2,7 @@ | |
|
||
from pathlib import Path | ||
|
||
from neptune_scale.exceptions import NeptuneLocalStorageInUnsupportedVersion | ||
from neptune_scale.sync.parameters import MAX_SINGLE_OPERATION_SIZE_BYTES | ||
|
||
__all__ = ("OperationsRepository", "OperationType", "Operation", "Metadata", "SequenceId") | ||
|
@@ -258,6 +259,9 @@ def get_metadata(self) -> Optional[Metadata]: | |
|
||
version, project, run_id, parent_run_id, fork_step = row | ||
|
||
if version != DB_VERSION: | ||
raise NeptuneLocalStorageInUnsupportedVersion() | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Maybe we should move the validation to constructor or dedicated method There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Left a comment elsewhere - let's remove it from here. |
||
|
||
return Metadata( | ||
version=version, project=project, run_id=run_id, parent_run_id=parent_run_id, fork_step=fork_step | ||
) | ||
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this method should become something like
_validate_existing_db()
and within it there should be: