Skip to content

Added support for family parameter #14

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Aug 13, 2024
Merged
Show file tree
Hide file tree
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .pre-commit-config.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@ repos:
args: [ --config-file, pyproject.toml ]
pass_filenames: false
additional_dependencies:
- neptune-api==0.3.0
- neptune-api==0.4.0
- more-itertools
default_language_version:
python: python3
2 changes: 1 addition & 1 deletion pyproject.toml
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ pattern = "default-unprefixed"
[tool.poetry.dependencies]
python = "^3.8"

neptune-api = "0.3.0"
neptune-api = "0.4.0"
more-itertools = "^10.0.0"

[tool.poetry]
Expand Down
4 changes: 2 additions & 2 deletions src/neptune_scale/__init__.py
Original file line number Diff line number Diff line change
Expand Up @@ -197,7 +197,7 @@ def _create_run(
creation_time=None if creation_time is None else datetime_to_proto(creation_time),
),
)
self._backend.submit(operation=operation)
self._backend.submit(operation=operation, family=self._family)
# TODO: Enqueue on the operations queue
# self._operations_queue.enqueue(operation=operation)

Expand Down Expand Up @@ -265,6 +265,6 @@ def log(
)

for operation in splitter:
self._backend.submit(operation=operation)
self._backend.submit(operation=operation, family=self._family)
# TODO: Enqueue on the operations queue
# self._operations_queue.enqueue(operation=operation)
4 changes: 2 additions & 2 deletions src/neptune_scale/api/api_client.py
Original file line number Diff line number Diff line change
Expand Up @@ -43,8 +43,8 @@ def __init__(self, api_token: str) -> None:
config, token_urls = get_config_and_token_urls(credentials=credentials)
self._backend = create_auth_api_client(credentials=credentials, config=config, token_refreshing_urls=token_urls)

def submit(self, operation: RunOperation) -> None:
_ = submit_operation.sync(client=self._backend, body=operation)
def submit(self, operation: RunOperation, family: str) -> None:
_ = submit_operation.sync(client=self._backend, family=family, body=operation)

def cleanup(self) -> None:
pass
Expand Down
Loading