Remove support for Python 3.8 #101
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kgodlewski
changed the title
kgodlewski
force-pushed
the
kg/python-3.9-typehints
branch
3 times, most recently
from
fb1d6fc to
b44e542
Compare
michalsosn
reviewed
Dec 17, 2024
| @@ -90,21 +84,21 @@ def __init__( | |||
| self, | |||
| *, | |||
| run_id: str, | |||
| project: Optional[str] = None, | |||
| api_token: Optional[str] = None, | |||
| project: str | None = None, | |||
There was a problem hiding this comment.
didn't | syntax for type union appear in python 3.10? at least that's what https://docs.python.org/3/library/typing.html#typing.Union says.
It should have failed in some tests on 3.9
There was a problem hiding this comment.
Seems like it should be so, however both mypy, and python 3.9 interpreter don't have issues with importing the code, which is quite weird, but I don't have the space to dig into this deeper -- I'll just go back to Optional
Make sure Python 3.13 is configured in all the tools.
# Conflicts: # CHANGELOG.md
kgodlewski
force-pushed
the
kg/python-3.9-typehints
branch
from
b44e542 to
4f14a11
Compare
This was done using `pyupgrade` # Conflicts: # src/neptune_scale/api/validation.py
kgodlewski
force-pushed
the
kg/python-3.9-typehints
branch
from
4f14a11 to
ffd8133
Compare
|
#105 contains changes without introducing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes:
pyupgrade --py39-pluson the codebase to change typehints to PEP585-styletyping.Callabletocollections.abc.Callable