fix: improve EOFError exception when remote nvim crashes #589
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wookayin
force-pushed
the
handle-process-termination
branch
2 times, most recently
from
82d798f to
290203f
Compare
justinmk
reviewed
Jan 10, 2025
wookayin
force-pushed
the
handle-process-termination
branch
2 times, most recently
from
5ff0407 to
06bfe75
Compare
|
Mind rebasing? |
Problem: When the remote Nvim instance is aborted or terminates, the
pynvim client will face an exception `OSError: EOF`. It is not very
clear what is wrong and why EOF is received.
Solution: This happens when the remote the nvim process terminates
unexpectedly (or a tcp/file socket is broken or gets disconnected). We
can provide a bit more detailed information about why the asyncio
session is stopping, through asyncio Protocol. An `EOFError` will be
raised instead of OSError.
For example, during pynvim's unit tests we may see:
```
EOFError: process_exited: pid = 40000, return_code = -6
```
which means that the Nvim subprocess (pid = 40000) exited unexpectedly
after getting SIGABRT (signal 6). Other error messages (different
signals such as SIGSEGV/segfault) or connection lost (when connected
through socket, etc.) are also possible.
wookayin
force-pushed
the
handle-process-termination
branch
from
06bfe75 to
7f0f4fb
Compare
|
Sorry for my recent inactivities. I've rebased and resolved the conflict, so please feel free to merge this one. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem: When the remote Nvim instance is aborted or terminates, the pynvim client will face an exception
OSError: EOF. It is not very clear what is wrong and why EOF is received.Solution: This happens when the remote the nvim process terminates unexpectedly (or a tcp/file socket is broken or gets disconnected). We can provide a bit more detailed information about why the asyncio session is stopping, through asyncio Protocol. An
EOFErrorwill be raised instead of OSError.For example, during pynvim's unit tests we may see:
which means that the Nvim subprocess (pid = 40000) exited unexpectedly after getting SIGABRT (signal 6), i.e. assertion failure. Other error messages such as SIGSEGV (signal 11) or connection lost (through socket) are also possible.