-
Notifications
You must be signed in to change notification settings - Fork 2.2k
chore: don't accept multiple arguments in :LspStop/LspRestart #3896
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -149,8 +149,8 @@ if vim.version.ge(vim.version(), { 0, 11, 2 }) then | |
end | ||
end) | ||
end, { | ||
desc = 'Restart the given client(s)', | ||
nargs = '*', | ||
desc = 'Restart the given client', | ||
nargs = '?', | ||
complete = complete_client, | ||
}) | ||
|
||
|
@@ -175,8 +175,8 @@ if vim.version.ge(vim.version(), { 0, 11, 2 }) then | |
end | ||
end | ||
end, { | ||
desc = 'Disable and stop the given client(s)', | ||
nargs = '*', | ||
desc = 'Disable and stop the given client', | ||
nargs = '?', | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Oh, I thought it would simplify the implementation too :) well, let's try it for now and see how it goes. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Yeah we still need to handle multiple servers in the default case with no arguments 😀 Thanks for the merge! |
||
complete = complete_client, | ||
}) | ||
|
||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
off-topic/future: why didn't we use
!
instead of++force
to "force" ...?