Skip to content

fix: support :LspRestart without arguments #3895

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 10, 2025

Conversation

toupeira
Copy link
Contributor

@toupeira toupeira commented Jun 9, 2025

Description

Problem:
After the refactoring in e4d1c8b for Neovim 0.11.2 this command now requires an argument.

Solution:
Restore the previous behaviour where :LspRestart defaults to restarting all active servers.

Context

Problem:
After the refactoring in e4d1c8b for Neovim 0.11.2 this command now
requires an argument.

Solution:
Restore the previous behaviour where `:LspRestart` defaults to
restarting all active servers.
@toupeira
Copy link
Contributor Author

toupeira commented Jun 9, 2025

@justinmk @haunt98 sorry I missed the LspRestart command in #3890 😀

I wasn't using this command so not 100% sure on the behaviour, but if I'm reading the old code correctly it restarted all active servers, not just those attached to the current buffer:

Is that correct?

@haunt98
Copy link

haunt98 commented Jun 10, 2025

Hi @toupeira , my neovim config only has golsp (lsp for go) so my usecase for LspRestart is only restart golsp quickly.

@justinmk
Copy link
Member

but if I'm reading the old code correctly it restarted all active servers, not just those attached to the current buffer:

I guess so. If people want granularity they can pass the config name.

@justinmk justinmk merged commit 77d3fdf into neovim:master Jun 10, 2025
6 checks passed
@toupeira toupeira deleted the fix/lsp-restart-without-arguments branch June 10, 2025 14:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

LspStart and LspRestart need an argument to run
3 participants