fix(mesonlsp): improved root detection #3775
Open
+26
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SpikedPaladin
force-pushed
the
fix-mesonlsp-root
branch
from
1febf14 to
afbd86a
Compare
justinmk
reviewed
Apr 25, 2025
justinmk
reviewed
Apr 25, 2025
| @@ -3,8 +3,33 @@ | |||
| --- https://github.com/JCWasmx86/mesonlsp | |||
| --- | |||
| --- An unofficial, unendorsed language server for meson written in C++ | |||
|
|
|||
| local meson_matcher = function(_, path) | |||
There was a problem hiding this comment.
docstring should give an example of the line this is trying to find. shouldn't have to study the code to figure that out.
There was a problem hiding this comment.
I don't understand what you mean, can you explain in more detail please?
There was a problem hiding this comment.
Suggested change
| local meson_matcher = function(_, path) | |
| --- Decides if a file is a meson file by looking for lines like: | |
| --- "foo.bar" or "baz" | |
| local meson_matcher = function(_, path) |
replace "foo.bar" with an actual example
This commit enhances root directory detection of mesonlsp language server. Current behavior: root is set on first meson file user is opened New behavior: root is set to parent of meson.build with project function call
SpikedPaladin
force-pushed
the
fix-mesonlsp-root
branch
from
afbd86a to
1a3a3f7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit enhances root directory detection of mesonlsp language server.
Current behavior:
rootis set on first meson file user is openedNew behavior:
rootis set to parent ofmeson.buildwithprojectfunction call