Master #2
Open
Master #2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The check for gathering a list of missing jobs that need to be added was comparing differently formatted job names, so it never found any matches.
The regex wasn’t finding all the jobs it needed to, so not enough TemplateJob objects were being created.
Simplifying code and moving the baseName to a parameter
Using the TemplateJob and ConcreteJob objects added needless complexity to the code. This version relies on strings of job names and branch names.
|
I can't merge your PR as in @9b41789 you have changed the way we handle feature names. If you can make that configurable that we can work with that. Thank you. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The check for gathering a list of missing jobs that need to be added
was comparing differently formatted job names, so it never found any
matches.