Revert "Update LLMInterface to restore LC compatibility" #433
+1,177
−989
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 7b4e2d3.
NathalieCharbel
approved these changes
Oct 16, 2025
There was a problem hiding this comment.
Just to keep track of my suggestion on how to deal with this, but needs further discussions offline to see whether it makes sense:
Keep the newly introduced param for LC compatibility i.e. LLMMessage but leave the invoke methods as they were before (i.e. without abstractions). The only drawback is that we will have the decorator for rate limit handling in all of the provider interfaces.
Approving this PR since it is just a revert and the solution can be done in a separate PR.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reverts #416