-
Notifications
You must be signed in to change notification settings - Fork 102
Explicit configuration of schema extraction #374
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from 1 commit
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -138,6 +138,14 @@ def test_simple_kg_pipeline_config_manual_schema() -> None: | |
assert isinstance(config._get_schema(), SchemaBuilder) | ||
|
||
|
||
def test_simple_kg_pipeline_config_literal_schema_validation() -> None: | ||
config = SimpleKGPipelineConfig(schema="NO_EXTRACTION") # type: ignore | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. looking at it here, I am wondering if "NO_EXTRACTION" is the best term to use? when putting it next to "AUTO_EXTRACTION" it makes sense but here it is a bit ambiguous? would "NO_SCHEMA" or "NO_GUIDING_SCHEMA" be better? as it does not only cover not being extracted but not provided at all? I am not strongly opinionated about it though as it is well-documented... There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Updated after private discussion |
||
assert config.schema_ == GraphSchema.create_empty() | ||
|
||
config = SimpleKGPipelineConfig(schema="AUTO_EXTRACTION") # type: ignore | ||
assert config.schema_ is None | ||
|
||
|
||
def test_simple_kg_pipeline_config_schema_run_params() -> None: | ||
config = SimpleKGPipelineConfig( | ||
entities=["Person"], | ||
|
Uh oh!
There was an error while loading. Please reload this page.