Skip to content

New schema and pruning #347

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 25 commits into from
Jun 11, 2025
Merged

Conversation

stellasia
Copy link
Contributor

@stellasia stellasia commented May 23, 2025

Description

Define how to prune the graph directly in the schema.

Type of Change

  • New feature
  • Bug fix
  • Breaking change
  • Documentation update
  • Project configuration change

Complexity

Complexity: Medium

How Has This Been Tested?

  • Unit tests
  • E2E tests
  • Manual tests

Checklist

The following requirements should have been met (depending on the changes in the branch):

  • Documentation has been updated
  • Unit tests have been updated
  • E2E tests have been updated
  • Examples have been updated
  • New files have copyright header
  • CLA (https://neo4j.com/developer/cla/) has been signed
  • CHANGELOG.md updated if appropriate

@stellasia stellasia requested a review from a team as a code owner May 23, 2025 15:04
Copy link
Contributor

@NathalieCharbel NathalieCharbel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall, very nice schema and pruning improvement, much better now!
I have a few comments though.
PS: my review does not include tests yet.

@stellasia stellasia force-pushed the feature/schema-driven-pruning branch 2 times, most recently from f627c4d to a1b5c8a Compare June 9, 2025 14:15
@stellasia stellasia force-pushed the feature/schema-driven-pruning branch from 8c5b8a2 to ea1e29e Compare June 10, 2025 15:45
Copy link
Contributor

@NathalieCharbel NathalieCharbel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for all the changes! nicely done 🙌🏻
The only thing that is left now is fixing CI checks

@stellasia stellasia merged commit e1941ed into neo4j:main Jun 11, 2025
7 of 11 checks passed
@stellasia stellasia deleted the feature/schema-driven-pruning branch June 16, 2025 15:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants