Fixed issue with bool props when generating an enhanced schema #333
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oskarhane
reviewed
May 8, 2025
Comment on lines
+756
to
+759
| if not output_dict: | ||
| return f"{match_clause}\nRETURN {{}} AS output" | ||
| # Combine with and return clauses | ||
| with_clause = "WITH " + ",\n ".join(with_clauses) | ||
| with_clause = "WITH " + ",\n ".join(with_clauses) if with_clauses else "" |
There was a problem hiding this comment.
Can you add a test that covers this?
There was a problem hiding this comment.
I've updated the unit tests to check the full query string returned by the get_enhanced_schema_cypher function.
The first two lines here are covered by the boolean, point, and duration cases of the test_get_enhanced_schema_cypher test.
The third line here is covered by the test_enhanced_schema_cypher_string_exhaustive_false_with_index test, previously the query generated by this test was:
MATCH (n:`Person`) WITH n LIMIT 5
WITH
RETURN {`status`: {values: ['Single', 'Married', 'Divorced'], distinct_count: 3}} AS output
Which is incorrect Cypher. As we didn't check the full query we didn't catch this.
oskarhane
approved these changes
May 13, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes an issue with the
get_enhanced_schema_cypherfunction which was failing if the schema included a boolean property.Type of Change
Complexity
Low
How Has This Been Tested?
Checklist
The following requirements should have been met (depending on the changes in the branch):