fix: config loading after module reload #288
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@ClemDoum thank you for opening the PR! Could you please sign the CLA here to pass the CLA check? |
|
@willtai I’ve sent the signed CLA on the 27th 🙂 |
|
I've resent the CLA and received confirmation again |
|
Hi @ClemDoum , It's on us, we've received your emails but a manual step was missing from our side to validate your signature. It's all set now and CLA check is passing. We will review the code in the coming days. |
stellasia
approved these changes
Mar 12, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When running jupyter notebook it's common to use auto reload:
With auto reload activated the builtin
issubclassno longer works as expected and config loading fails (see unit test)Type of Change
Complexity
Complexity: low
How Has This Been Tested?
Checklist