-
Notifications
You must be signed in to change notification settings - Fork 108
Refactors index functions #269
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
This will be a breaking change. Why do we make this change in this PR? |
We don't necessarily. Happy to remove it and make the change in another PR. It just felt like given I was already refactoring these functions now might be a good time to do it. I think there have also been a few releases now since the warning this property would be removed was added. |
@CodiumAI-Agent /update_changelog |
Changelog updates: 🔄 2025-02-12 *Added
Changed
|
Don't think we need it for this PR. We can remove it in a separate PR, wdyt? |
Changelog updates: 🔄 2025-02-13Added
Changed
|
Makes sense. I'll add something to the backlog to remind us to deprecate it at some point in the future. Have re-added it in e773de4. PR should no longer have any breaking changes in it. |
d967bea
to
0406a27
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
☄️
Description
This PR refactors the code for interacting with vector and hybrid indexes. Key changes include:
get_search_query
to make it compatible with LangChain Neo4j.retrieve_fulltext_index_info
utility function: Retrieves metadata about existing full-text indexes.retrieve_vector_index_info
utility function: Retrieves metadata about existing vector indexes.effective_search_ratio
parameter for vector and hybrid search.Type of Change
Complexity
Complexity: Medium
How Has This Been Tested?
Checklist
The following requirements should have been met (depending on the changes in the branch):