LLM interface function calling and implementation for OpenAILLM #268
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
willtai
force-pushed
the
LLMInterface-function-calling
branch
2 times, most recently
from
255f481 to
0278184
Compare
willtai
changed the title
willtai
force-pushed
the
LLMInterface-function-calling
branch
from
1a9aa2d to
bda358a
Compare
stellasia
reviewed
Feb 13, 2025
| """ | ||
|
|
||
|
|
||
| rag = GraphRAG(retriever=retriever, llm=llm) |
There was a problem hiding this comment.
Maybe this example needs to be updated to remove the GraphRAG part?
There was a problem hiding this comment.
I wanted to show an example of how the tool can be used after being called. I was thinking to keep unless you prefer to have it removed to just show the tool call?
There was a problem hiding this comment.
I'm a bit uncomfortable with it at the moment, but it's mainly because of our design: using the same llm object which has the tool definition (in model_params), we have to say in the prompt "do not use any tool", which I feel is the way it is intended to be used. We might have to reconsider this design before using this new feature in that way. WDYT?
willtai
force-pushed
the
LLMInterface-function-calling
branch
from
1376ad7 to
4801ed0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR enables function calling for the OpenAILLM. It updates the
OpenAILLMclass and alsoLLMInterfacetype. An example script is also added.Type of Change
Complexity
Complexity: Low
How Has This Been Tested?
Checklist
The following requirements should have been met (depending on the changes in the branch):