Skip to content

Improve import system #175

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 10 commits into from
Oct 24, 2024
Merged

Improve import system #175

merged 10 commits into from
Oct 24, 2024

Conversation

jonbesga
Copy link
Contributor

@jonbesga jonbesga commented Oct 9, 2024

Description

Note

Please provide a description of the work completed in this PR below

Type of Change

  • New feature
  • Bug fix
  • Breaking change
  • Documentation update
  • Project configuration change

Complexity

Note

Please provide an estimated complexity of this PR of either Low, Medium or High

Complexity:

How Has This Been Tested?

  • Unit tests
  • E2E tests
  • Manual tests

Checklist

The following requirements should have been met (depending on the changes in the branch):

  • Documentation has been updated
  • Unit tests have been updated
  • E2E tests have been updated
  • Examples have been updated
  • New files have copyright header
  • CLA (https://neo4j.com/developer/cla/) has been signed
  • CHANGELOG.md updated if appropriate

@jonbesga jonbesga requested a review from a team as a code owner October 9, 2024 22:48
Copy link
Contributor

@willtai willtai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice one! What do you think of doing the same for the external retrievers: Pinecone, Weaviate, and Qdrant? If not we can do this in a separate PR

@jonbesga
Copy link
Contributor Author

Nice one! What do you think of doing the same for the external retrievers: Pinecone, Weaviate, and Qdrant? If not we can do this in a separate PR

Yep. I'll do the same for everything. But Qdrant has a PR open so maybe leave that for when that PR is merged?

@jonbesga jonbesga requested a review from stellasia October 11, 2024 08:32
@jonbesga jonbesga force-pushed the jonbesga/import-system branch from 8fe26cc to bcd9101 Compare October 11, 2024 08:47
@jonbesga
Copy link
Contributor Author

Nice one! What do you think of doing the same for the external retrievers: Pinecone, Weaviate, and Qdrant? If not we can do this in a separate PR

Actually, I'll do it in a separate PR

@jonbesga jonbesga force-pushed the jonbesga/import-system branch 2 times, most recently from 1fd6617 to ca4be0b Compare October 23, 2024 08:41
@jonbesga jonbesga requested a review from stellasia October 23, 2024 08:51
@jonbesga jonbesga force-pushed the jonbesga/import-system branch from c554143 to e46c2ca Compare October 24, 2024 08:57
Copy link
Contributor

@stellasia stellasia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👩🏽‍🚒

@jonbesga jonbesga force-pushed the jonbesga/import-system branch from e46c2ca to 3fc623a Compare October 24, 2024 09:28
@jonbesga jonbesga merged commit bc8540e into main Oct 24, 2024
9 checks passed
@jonbesga jonbesga deleted the jonbesga/import-system branch October 24, 2024 12:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants