Skip to content

Restructure examples folder #146

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 44 commits into from
Oct 21, 2024
Merged

Restructure examples folder #146

merged 44 commits into from
Oct 21, 2024

Conversation

stellasia
Copy link
Contributor

@stellasia stellasia commented Sep 23, 2024

Description

Note

Please provide a description of the work completed in this PR below

Type of Change

  • New feature
  • Bug fix
  • Breaking change
  • Documentation update
  • Project configuration change

Complexity

Note

Please provide an estimated complexity of this PR of either Low, Medium or High

Complexity:

How Has This Been Tested?

  • Unit tests
  • E2E tests
  • Manual tests

Checklist

The following requirements should have been met (depending on the changes in the branch):

  • Documentation has been updated
  • Unit tests have been updated
  • E2E tests have been updated
  • Examples have been updated
  • New files have copyright header
  • CLA (https://neo4j.com/developer/cla/) has been signed
  • CHANGELOG.md updated if appropriate

…into examples

# Conflicts:
#	examples/old/pipeline/kg_builder.py
…into examples

# Conflicts:
#	examples/old/pipeline/Harry Potter and the Chamber of Secrets Summary.pdf
#	examples/old/pipeline/kg_builder_example.py
#	examples/old/pipeline/kg_builder_two_documents_entity_resolution.py
…om doc - need to keep the file until the next release but then remove
@stellasia stellasia marked this pull request as ready for review October 11, 2024 07:27
@stellasia stellasia requested a review from a team as a code owner October 11, 2024 07:27

- Build Knowledge Graph from PDF or text
- Retrieve information from the graph
- Answer questions
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Instead of "answer", shall we have "Question Answering" / qa, as this is the common term in literature

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

query_text = "Find me a book about Fremen"
print(
retriever.search(
query_text=query_text, top_k=1, filters={"int_property": {"$gt": 100}}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe worth having the prefilters as a separate variable for explicitness

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

…into examples

# Conflicts:
#	examples/customize/retrievers/external/pinecone/pinecone_vector_search.py
#	examples/customize/retrievers/external/weaviate/weaviate_text_search_local_embedder.py
#	examples/openai_search.py
@stellasia stellasia merged commit ca86f26 into neo4j:main Oct 21, 2024
7 checks passed
@stellasia stellasia deleted the examples branch December 11, 2024 14:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants