Async pipeline improvements #123
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…to fix/async-pipeline
…to fix/async-pipeline
…to async-pipeline-improvements
…o async-pipeline-improvements
…to async-pipeline-improvements # Conflicts: # src/neo4j_genai/experimental/pipeline/pipeline.py # src/neo4j_genai/experimental/pipeline/stores.py # tests/e2e/test_kg_builder_pipeline_e2e.py # tests/unit/experimental/pipeline/test_orchestrator.py
willtai
reviewed
Sep 9, 2024
willtai
reviewed
Sep 9, 2024
…Remove unused statuses
a-s-g93
pushed a commit
to a-s-g93/neo4j-genai-python-dev
that referenced
this pull request
Sep 13, 2024
* Add failing test * Define a "run_id" in Orchestrator - save results per run_id * Make unit test work * Make intermediate results accessible from outside pipeline for investigation * Remove unused imports * Update examples and CHANGELOG * Cleaning: remove deprecated code * Fix ruff * Fix examples * Fix examples again * Move status to store * PR reviews * Removing useless status assignment * Remove unused import * Move status to store * Return RunStatus from method * Fix bad merge * Fix comments * Deal with None statuses in the method dedicated to fetching status - Remove unused statuses * Fix error message * Update error message
a-s-g93
pushed a commit
to a-s-g93/neo4j-genai-python-dev
that referenced
this pull request
Sep 13, 2024
* Add failing test * Define a "run_id" in Orchestrator - save results per run_id * Make unit test work * Make intermediate results accessible from outside pipeline for investigation * Remove unused imports * Update examples and CHANGELOG * Cleaning: remove deprecated code * Fix ruff * Fix examples * Fix examples again * Move status to store * PR reviews * Removing useless status assignment * Remove unused import * Move status to store * Return RunStatus from method * Fix bad merge * Fix comments * Deal with None statuses in the method dedicated to fetching status - Remove unused statuses * Fix error message * Update error message
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR doesn't fix anything but is a follow-up of #119 , where the component status are moved to the store instead of being saved into the task class, for consistency (the task results are already saved in the store).
Type of Change
Complexity
Complexity: Medium
How Has This Been Tested?
Checklist
The following requirements should have been met (depending on the changes in the branch):