Skip to content

Bugfix/docker hub login #108

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Aug 21, 2024

Conversation

alexthomas93
Copy link
Contributor

Description

This PR adds a Docker Hub log in step to the services section of the CI/CD E2E tests in order to fix rate limit issues.

Type of Change

  • New feature
  • Bug fix
  • Breaking change
  • Documentation update
  • Project configuration change

Complexity

Complexity: Low

How Has This Been Tested?

  • Unit tests
  • E2E tests
  • Manual tests

Checklist

The following requirements should have been met (depending on the changes in the branch):

  • Documentation has been updated
  • Unit tests have been updated
  • E2E tests have been updated
  • Examples have been updated
  • New files have copyright header
  • CLA (https://neo4j.com/developer/cla/) has been signed
  • CHANGELOG.md updated if appropriate

@alexthomas93 alexthomas93 requested review from team-gen-ai and a team August 21, 2024 08:23
Copy link
Member

@oskarhane oskarhane left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🖲️

@alexthomas93 alexthomas93 merged commit 6e544df into neo4j:main Aug 21, 2024
11 checks passed
@alexthomas93 alexthomas93 deleted the bugfix/docker-hub-login branch August 21, 2024 11:58
a-s-g93 pushed a commit to a-s-g93/neo4j-genai-python-dev that referenced this pull request Sep 13, 2024
* Added Docker Hub login to E2E tests

* Weaviate container is now pulled from Docker Hub

* Reverted cr.weaviate.io removal from E2E tests

* Retriggering E2E tests

* Removed Docker Hub login from PR E2E tests
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants