-
Notifications
You must be signed in to change notification settings - Fork 54
V2 Support similarity algos - Part 1 #977
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
FlorentinD
wants to merge
13
commits into
neo4j:main
Choose a base branch
from
FlorentinD:gdsa-271-implement-similarity-algos
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
V2 Support similarity algos - Part 1 #977
FlorentinD
wants to merge
13
commits into
neo4j:main
from
FlorentinD:gdsa-271-implement-similarity-algos
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for neo4j-graph-data-science-client canceled.
|
3d5e8ab
to
cf6fff6
Compare
FlorentinD
commented
Oct 9, 2025
graphdatascience/procedure_surface/arrow/relationship_endpoints_helper.py
Outdated
Show resolved
Hide resolved
FlorentinD
commented
Oct 13, 2025
cf6fff6
to
6cecccc
Compare
DarthMax
requested changes
Oct 16, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! I added a couple of suggestions and requests
graphdatascience/procedure_surface/api/similarity/knn_endpoints.py
Outdated
Show resolved
Hide resolved
graphdatascience/procedure_surface/api/similarity/knn_endpoints.py
Outdated
Show resolved
Hide resolved
graphdatascience/procedure_surface/api/similarity/knn_endpoints.py
Outdated
Show resolved
Hide resolved
graphdatascience/tests/integrationV2/procedure_surface/conftest.py
Outdated
Show resolved
Hide resolved
...ests/integrationV2/procedure_surface/cypher/similarity/test_knn_filtered_cypher_endpoints.py
Outdated
Show resolved
Hide resolved
...ests/integrationV2/procedure_surface/cypher/similarity/test_knn_filtered_cypher_endpoints.py
Outdated
Show resolved
Hide resolved
...ests/integrationV2/procedure_surface/cypher/similarity/test_knn_filtered_cypher_endpoints.py
Outdated
Show resolved
Hide resolved
...tascience/tests/integrationV2/procedure_surface/arrow/similarity/test_knn_arrow_endpoints.py
Show resolved
Hide resolved
with the latest session release we can call the endpoints without a seg fault
also remove write_to_resultstore param
easier to also replace with an address of your own
a6d5f31
to
11ec04e
Compare
FlorentinD
commented
Oct 16, 2025
...hdatascience/tests/integrationV2/procedure_surface/session/test_session_endpoint_coverage.py
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.