Release 5.1.5 #63
Merged
Release 5.1.5 #63
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added payload mode documentation
fbiville
reviewed
Oct 29, 2024
Co-authored-by: Florent Biville <445792+fbiville@users.noreply.github.com>
Co-authored-by: Florent Biville <445792+fbiville@users.noreply.github.com>
Co-authored-by: Florent Biville <445792+fbiville@users.noreply.github.com>
fbiville
approved these changes
Oct 29, 2024
nvitucci
reviewed
Oct 29, 2024
nvitucci
approved these changes
Oct 29, 2024
ali-ince
requested changes
Oct 29, 2024
|
|
||
| == Compatibility with Sink Connectors | ||
|
|
||
| The `EXTENDED` format was introduced in connector version 5.1.0 to ensure that all data published to Kafka topics adheres to a consistent schema. This prevents issues when a property changes type on the Neo4j side (e.g., a name property changes from integer to string), enabling smooth data processing across connectors and Kafka consumers. |
There was a problem hiding this comment.
Should we also mention that if there is a Neo4j sink connector instance which is fed from a Neo4j source connector, they should stick with EXTENDED mode.
Co-authored-by: Ali Ince <ali-ince@users.noreply.github.com>
|
Thanks for the documentation updates. The preview documentation has now been torn down - reopening this PR will republish it. |
fbiville
reviewed
Oct 30, 2024
|
|
||
| == Compatibility with Sink Connectors | ||
|
|
||
| The `EXTENDED` format was introduced in connector version 5.1.0 to ensure that all data published to Kafka topics adheres to a consistent schema. This prevents issues when a property changes type on the Neo4j side (e.g., a name property changes from integer to string), enabling smooth data processing across connectors and Kafka consumers. When a Neo4j sink connector is fed by a Neo4j source connector, it’s recommended to use `EXTENDED` mode, as the Neo4j sink connector can seamlessly handle the `EXTENDED` data type. |
There was a problem hiding this comment.
do COMPACT source data work with sinks in some circumstances?
if it never works, I'd use stronger language in the last sentence. Something like "EXTENDED mode must be used with sinks..."
There was a problem hiding this comment.
yes, you can use it as long as you comply with COMPACT mode limitations like preventing property type changes and temporal types for protobuf
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.