Add cdc source value serialization types #48
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ali-ince
reviewed
Aug 30, 2024
| @@ -50,6 +50,12 @@ One of `SKIP`, `ELEMENT_ID`, `ENTITY_KEYS`, `WHOLE_VALUE`. | |||
|
|
|||
| Default: `WHOLE_WALUE` | |||
|
|
|||
| | neo4j.cdc.topic.\{NAME}.value-strategy | |||
| | Serialisation strategy for CDC topic key. | |||
| One of `CHANGE_EVENT`, `ENTITY_EVENT`. | |||
There was a problem hiding this comment.
I think we should note that sink connector with one of the CDC strategies require CHANGE_EVENT.
ali-ince
reviewed
Sep 4, 2024
ali-ince
reviewed
Sep 4, 2024
There was a problem hiding this comment.
Left one final comment @Emrehzl94. Then we can ask @nvitucci for a review.
Co-authored-by: Ali Ince <ali-ince@users.noreply.github.com>
ali-ince
approved these changes
Sep 4, 2024
|
Thanks for the documentation updates. The preview documentation has now been torn down - reopening this PR will republish it. |
|
LGTM |
nvitucci
approved these changes
Sep 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.