-
Notifications
You must be signed in to change notification settings - Fork 13
Document GraphQL API for GA release #264
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
is this only going to be available in 7.x? |
It's a new product that will only support v7 of the library. I think it should probably only be included in the v7 version of the docs going forwards as users looking at v6 or older would need to upgrade to v7 before they can make use of the feature anyway |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's slightly jarring having essentially a getting started guide for both the console and cli mixed together. Would it be feasible to refactor this into two separate guides?
This would also make it easier to add docs on how to enable to CLI feature flag. We also might want to add "Getting Started Using the Aura API" docs in the future and they'd fit better the separate getting started guide format imo
I know there's not too long to get this done though as the GA just around the corner so it might be something for a follow-up PR
|
||
|
||
== Aura CLI | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've just seen the docs on using the CLI, maybe this should just link to those?
Co-authored-by: Liam-Doodson <114480811+Liam-Doodson@users.noreply.github.com>
works for me Co-authored-by: Liam-Doodson <114480811+Liam-Doodson@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks fine to me
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've just added a few comments for consistency of the commands but other than those this LGTM
Co-authored-by: Liam-Doodson <114480811+Liam-Doodson@users.noreply.github.com>
Co-authored-by: Liam-Doodson <114480811+Liam-Doodson@users.noreply.github.com>
This PR includes documentation updates New pages:
Updated pages: |
No description provided.