Add deprecations introduced in v6 #249
Conversation
angrykoala
commented
Mar 18, 2025
angrykoala
commented
- Remove additions section in migration guide
- Add new deprecations that have been introduced in version 6
| [source, graphql, indent=0] | ||
| ---- | ||
| type Movie implements Production @node { | ||
| title: String! @unique | ||
| actors: [Actor!]! @relationship(type: "ACTED_IN", direction: IN, properties: "ActedIn") | ||
| } | ||
| ---- |
There was a problem hiding this comment.
what can a user do to achieve something similar?
There was a problem hiding this comment.
I don't think we really provide any alternative to this at the moment. The issue with @unique is that it isn't really supported by neo4j itself, so it is very unreliable
There was a problem hiding this comment.
could/should we communicate the fact that it was unreliable? (unreliable how? no way of ensuring uniqueness?)
There was a problem hiding this comment.
There were some cases in which the uniqueness could not be enforced, leading to data that doesn't match the schema. I'm not sure how to properly communicate this
There was a problem hiding this comment.
Do we usually write motivations for deprecations?
Perhaps we can write something like this:
The
@uniquedirective has been removed as it could not always be reliably enforced, potentially leading to data inconsistencies that did not match the schema.
|
|
||
| === Deprecated `*aggregate` fields | ||
|
|
||
| Top level and nested `*Aggregate` fields have been deprecated in favor of `aggregate` fields inside connections: |
There was a problem hiding this comment.
| Top level and nested `*Aggregate` fields have been deprecated in favor of `aggregate` fields inside connections: | |
| Top level and nested `*Aggregate` fields have been deprecated in favor of `aggregate` fields inside connections: |
There was a problem hiding this comment.
I think this one was correct, for instance moviesAggregate has the casing as Aggregate
There was a problem hiding this comment.
in the heading (line 630) it was lower case, likewise in the text following the code listing (line 664).
let's make it consistent then :)
There was a problem hiding this comment.
The mixed casing seems to be important in this. *Aggregate (note the *) for example moviesAggregate, has been removed, and replaced with a aggregate.
There was a problem hiding this comment.
so upper case for all "*" ?
Co-authored-by: Richard Sill <156673635+rsill-neo4j@users.noreply.github.com>
Co-authored-by: Richard Sill <156673635+rsill-neo4j@users.noreply.github.com>
Co-authored-by: Richard Sill <156673635+rsill-neo4j@users.noreply.github.com>
Co-authored-by: Richard Sill <156673635+rsill-neo4j@users.noreply.github.com>
|
Thanks for the documentation updates. The preview documentation has now been torn down - reopening this PR will republish it. |
