Skip to content

fix subscription docs #154

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jun 10, 2024
Merged

fix subscription docs #154

merged 2 commits into from
Jun 10, 2024

Conversation

rsill-neo4j
Copy link
Contributor

@rsill-neo4j rsill-neo4j commented Jun 5, 2024 •
edited
Loading

closes: #153

@rsill-neo4j rsill-neo4j requested a review from mjfwebb June 5, 2024 10:58
@rsill-neo4j
Copy link
Contributor Author

should this also be fixed for older versions?

@rsill-neo4j rsill-neo4j requested a review from darrellwarde June 5, 2024 10:59
@mjfwebb
Copy link
Contributor

mjfwebb commented Jun 5, 2024

should this also be fixed for older versions?

That would be great if possible

darrellwarde
darrellwarde previously requested changes Jun 5, 2024
View reviewed changes
Copy link
Contributor

@darrellwarde darrellwarde left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks good, actually an additional change needed though!

@darrellwarde
Copy link
Contributor

should this also be fixed for older versions?

That would be great if possible

I don't know exactly when we made this change though.

@darrellwarde
Copy link
Contributor

I just checked - it was changed in version 4, so those docs can also be updated!

@rsill-neo4j @darrellwarde
Apply suggestions from code review
8f07f3d 
Co-authored-by: Darrell Warde <8117355+darrellwarde@users.noreply.github.com>
@neo-technology-commit-status-publisher
Copy link
Collaborator

neo-technology-commit-status-publisher commented Jun 5, 2024 •
edited
Loading

Thanks for the documentation updates.

The preview documentation has now been torn down - reopening this PR will republish it.

@mjfwebb mjfwebb dismissed darrellwarde’s stale review June 10, 2024 07:11

Changes have been implemented

@rsill-neo4j rsill-neo4j merged commit cdb05c4 into 5.x Jun 10, 2024
rsill-neo4j added a commit that referenced this pull request Jun 10, 2024
@rsill-neo4j
Merge pull request #154 from neo4j/fix-for-subscription-docs
5b1d1c6 
fix subscription docs
rsill-neo4j added a commit that referenced this pull request Jun 10, 2024
@rsill-neo4j
Merge pull request #154 from neo4j/fix-for-subscription-docs
bab11aa 
fix subscription docs
@rsill-neo4j
Copy link
Contributor Author

also applied this to 6.x and 4.x

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mjfwebb mjfwebb mjfwebb approved these changes

@darrellwarde darrellwarde darrellwarde left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Documentation issue for subscription directive
4 participants
@rsill-neo4j @mjfwebb @darrellwarde @neo-technology-commit-status-publisher