Skip to content

Vector index search directives #139

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 19 commits into from
Jul 12, 2024
Merged

Vector index search directives #139

merged 19 commits into from
Jul 12, 2024

Conversation

rsill-neo4j
Copy link
Contributor

@rsill-neo4j rsill-neo4j commented Apr 29, 2024 •
edited
Loading

No description provided.

lidiazuin
lidiazuin reviewed May 2, 2024
View reviewed changes
rsill-neo4j and others added 2 commits May 2, 2024 16:31
@rsill-neo4j @lidiazuin
Apply suggestions from code review
8b3368d 
Co-authored-by: Lidia Zuin <102308961+lidiazuin@users.noreply.github.com>
@rsill-neo4j
review suggestions
3adf8bb
lidiazuin
lidiazuin approved these changes May 3, 2024
View reviewed changes
Copy link
Contributor

@lidiazuin lidiazuin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All looking good to me, just the last two code blocks are still missing for they are WIP 😁

@rsill-neo4j rsill-neo4j marked this pull request as ready for review July 4, 2024 16:33
@rsill-neo4j
Copy link
Contributor Author

@lidiazuin
this is also genAI related. should we add a link in https://neo4j.com/docs/genai/ ? (it's not super evident that it is a genAI feature in the graphQL documentation, because it also makes sense to have it under "indexes and constraints" in the directives page)

@lidiazuin
Copy link
Contributor

@lidiazuin this is also genAI related. should we add a link in https://neo4j.com/docs/genai/ ? (it's not super evident that it is a genAI feature in the graphQL documentation, because it also makes sense to have it under "indexes and constraints" in the directives page)

Yep! We totally should link this content there. As soon as it's published, I can do that. :)

mjfwebb
mjfwebb requested changes Jul 8, 2024
View reviewed changes
rsill-neo4j and others added 3 commits July 8, 2024 16:40
@rsill-neo4j
added two links
f734cd8
@rsill-neo4j @mjfwebb
Apply suggestions from code review
5a18e8b 
Co-authored-by: Michael Webb <28074382+mjfwebb@users.noreply.github.com>
@rsill-neo4j
review suggestions
895ba21
mjfwebb
mjfwebb requested changes Jul 9, 2024
View reviewed changes
@neo-technology-commit-status-publisher
Copy link
Collaborator

neo-technology-commit-status-publisher commented Jul 11, 2024 •
edited
Loading

Thanks for the documentation updates.

The preview documentation has now been torn down - reopening this PR will republish it.

@rsill-neo4j rsill-neo4j merged commit acc02f5 into 5.x Jul 12, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mjfwebb mjfwebb mjfwebb approved these changes

@lidiazuin lidiazuin lidiazuin approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@rsill-neo4j @lidiazuin @neo-technology-commit-status-publisher @mjfwebb