graph references in Cypher 25 #1295
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hunterness
reviewed
Jun 2, 2025
ConorNeo
approved these changes
Jun 4, 2025
|
This PR includes documentation updates Updated pages: |
Hunterness
reviewed
Jun 5, 2025
|
|
||
| * `++USE graph.propertiesByName('database.with.dot')++` | ||
| | | ||
| The graph name ``composite.with.dot`.constituent` is deprecated. It is replaced by ``composite.with.dot`.constituent`. |
There was a problem hiding this comment.
isn't your replacement the exact same thing as the deprecated one? 🤔
There was a problem hiding this comment.
Suggested change
| The graph name ``composite.with.dot`.constituent` is deprecated. It is replaced by ``composite.with.dot`.constituent`. | |
| The graph name ``composite.with.dot`.constituent` is deprecated. It is replaced by ``composite.with.dot.constituent``. |
There was a problem hiding this comment.
I don't think just the fix above of moving a ` will help but there is also in general something up with the formatting:
Comment on lines
+182
to
+184
| In Cypher 5, there was some special logic for composite databases or constituents with dots, | ||
| which required quotes around those name parts in order to find the name. This deprecations apply to xref::values-and-types/graph-references.adoc[Graph references] in arguments of the functions xref:functions/graph.adoc#functions-graph-byname[`graph.byName`] and xref:functions/graph.adoc#functions-graph-propertiesByName[`graph.propertiesByName`]. In Cypher 25 the graph references can be passed in without quoting | ||
| as in the name column from `SHOW ALIASES FOR DATABASE`.Note that escaping graph names within the graph functions string argument is not supported in Cypher 5. |
There was a problem hiding this comment.
Suggested change
| In Cypher 5, there was some special logic for composite databases or constituents with dots, | |
| which required quotes around those name parts in order to find the name. This deprecations apply to xref::values-and-types/graph-references.adoc[Graph references] in arguments of the functions xref:functions/graph.adoc#functions-graph-byname[`graph.byName`] and xref:functions/graph.adoc#functions-graph-propertiesByName[`graph.propertiesByName`]. In Cypher 25 the graph references can be passed in without quoting | |
| as in the name column from `SHOW ALIASES FOR DATABASE`.Note that escaping graph names within the graph functions string argument is not supported in Cypher 5. | |
| In Cypher 5, there was some special logic for composite databases or constituents with dots, which required quotes around those name parts in order to find the name. | |
| This deprecations apply to xref::values-and-types/graph-references.adoc[Graph references] in arguments of the functions xref:functions/graph.adoc#functions-graph-byname[`graph.byName`] and xref:functions/graph.adoc#functions-graph-propertiesByName[`graph.propertiesByName`]. | |
| In Cypher 25 the graph references can be passed in without quoting as in the name column from `SHOW ALIASES FOR DATABASE`. | |
| Note that escaping graph names within the graph functions string argument is not supported in Cypher 5. |
Usually we split the lines between sentences and not in the middle of sentences
| @@ -174,20 +174,14 @@ label:functionality[] | |||
| label:updated[] | |||
There was a problem hiding this comment.
since this is talking about deprecations/removals it should probably not be under the updated in Cypher 25 section, the deprecated bit should probably be in a Deprecated features section (not related to Cypher 25) and then in Removed in Cypher 25 for the breaking change part 🤔
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.