-
Notifications
You must be signed in to change notification settings - Fork 60
Updated images #1210
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updated images #1210
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @lidiazuin.
The images look good, except for:
- graph_clause_where.svg (the replacement replaces the old image)
- patterns-equijoins-solution_2.svg (I think the different solutions are less clear in this new format).
Also, how are you batching these updates? I see, e.g., that this PR replaces some but not all of the svgs in the Patterns chapter? Are those not replaced here not ready yet?
@@ -678,7 +678,7 @@ RETURN type(r) AS type, m.title AS movie | |||
|
|||
The result shows that he has 13 outgoing relationships connected to 12 different `Movie` nodes (12 have the `ACTED_IN` type and one has the `DIRECTED` type). | |||
|
|||
image::introduction_example1.svg[width="500",role="middle"] | |||
image::introduction-example1.svg[A Tom Hanks nodes connecting to Movie nodes via acted in relationships,width=600,role=popup] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
image::introduction-example1.svg[A Tom Hanks nodes connecting to Movie nodes via acted in relationships,width=600,role=popup] | |
image::introduction-example1.svg[A Tom Hank Person node connected to Movie nodes via acted in relationships,width=600,role=popup] |
Co-authored-by: Jens Pryce-Åklundh <112686610+JPryce-Aklundh@users.noreply.github.com>
I don't understand your point here?
Isn't it the same image, only the nodes are organized differently? Maybe you can talk to Petar and explain to him what improvements could be made.
I'm adding all the images that Petar finished and sent to me in the first batch. I don't know in what order he's working with the images, but I would guess it's not after chapters since we have some missing, like the ones you pointed out. |
|
Would you like to revert the change in these two images and merge to publish the new ones or wait? |
where_clause.svg should be reverted, but I actually think it might be better to wait adding the images in the Patterns section until they are all done (i.e. all "patterns... .svg" files). |
This PR includes documentation updates Updated pages: |
…of images that are not being used but were updated
This PR includes documentation updates Updated pages: |
@@ -2,6 +2,12 @@ | |||
[[syntax-and-semantics]] | |||
= Syntax and semantics | |||
|
|||
//Check Mark |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What does this do? (Preview isnt working)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
…of images that are not being used but were updated
Publish from all the branches
Co-authored-by: AlexicaWright <49636617+AlexicaWright@users.noreply.github.com> Co-authored-by: Jens Pryce-Åklundh <112686610+JPryce-Aklundh@users.noreply.github.com> Co-authored-by: David Oliver <davidoliverSP2@users.noreply.github.com> Co-authored-by: Arne Fischereit <arne.fischereit@neo4j.com> Co-authored-by: Tobias Johansson <tobias.j.e.johansson@gmail.com> Co-authored-by: Gemma Lamont <gemma.lamont@neotechnology.com> Co-authored-by: lidiazuin <102308961+lidiazuin@users.noreply.github.com> Co-authored-by: Therese Magnusson <therese.magnusson@neotechnology.com> Co-authored-by: JPryce-Aklundh <jpryce-aklundh@neo4j.com> Co-authored-by: Louise Söderström <louise.soderstrom@neo4j.com> Co-authored-by: Jack Waudby <33488812+jackwaudby@users.noreply.github.com> Co-authored-by: Satia Herfert <satiaherfert@gmx.de> Co-authored-by: Gustav Hedengran <gustav.hedengran@gmail.com>
Feature merged in 5.3 but hidden behind feature flag, the flag was turned true by default in 5.4.
This makes the example always return the same result by enforcing an ordering, so that we don't need to skip testing its result (this PR updates neo4j#405). The sense of the example is unaffected.
Original PR: neo4j#464 Cherry-pick excludes 5.6 specific content in original PR Co-authored-by: Therese Magnusson <therese.magnusson@neotechnology.com>
Original PR: neo4j#494
Co-authored-by: Satia Herfert <satiaherfert@gmx.de> Co-authored-by: Hannes Sandberg <hannes.sandberg@neotechnology.com> Co-authored-by: Nacho Cordón <ncordon@users.noreply.github.com> Co-authored-by: Therese Magnusson <therese.magnusson@neotechnology.com> Co-authored-by: Pontus Melke <pontusmelke@gmail.com>
Cherry-picked from neo4j#552
Co-authored-by: Jens Pryce-Åklundh <112686610+JPryce-Aklundh@users.noreply.github.com> Co-authored-by: Bastien Louërat <bastien.louerat@neo4j.com> Co-authored-by: Therese Magnusson <therese.magnusson@neotechnology.com> Co-authored-by: Lasse Heemann <lasse.heemann@neo4j.com>
This PR updates 5.x with updates from PRs into dev that were not cherry-picked into 5.x at any point. While it looks like a lot of commits were missing, in the end it amounts to changes in 14 files, some of which are trivial and do not affect the content or output. I'd be happy to use 'squash and merge' to reduce this update to a single commit in 5.x
Thanks for the documentation updates. The preview documentation has now been torn down - reopening this PR will republish it. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🎉
No description provided.