-
Notifications
You must be signed in to change notification settings - Fork 27
Dashboard import feature #758
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
| Single value | ✅ | ||
| Raw JSON | ❌ | ||
| Parameter select | Only node and relationship properties | ||
| Form | Only node and relationship properties |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
NeoDash reports of type form
are skipped.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall looks good to me. As we discussed the details will change a bit, in particular I'll make the detail path in the JSON more human-friendly.
I wonder if we should add a note stating that for the moment we only support NeoDash imports but Aura dashboards imports are coming soon.
|
||
If the dashboard specification selected for the import is syntactically correct, the **Import dashboard** dialog displays a **Summary** and **Details** for the import. | ||
This means that the import can be run. | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[NOTE] | |
==== | |
Currently, Aura dashboards only support the import of NeoDash dashboard specifications. | |
==== |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
added this note, but let's avoid making promises in the docs :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lets remember to remove this note in a couple of weeks
In the **Import dashboard** dialog, you have several options to source the dashboard specification for the import: | ||
|
||
* Browse for a JSON file on your machine. | ||
* Select a dashboard specification that is stored in your database. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
'dashboard specification' sounds a bit awkward - is dashboard instance/dashboard save better?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe also explicitly call out that dashboards stored in the database is a legacy storage mechanism
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
hm... what do we call it internally?
it's not quite the dashboard itself, rather the stored version of it, or the JSON representation of a dashboard
legacy storage mechanism as in we discourage users?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Imo, good options are "dashboard JSON" or more verbose "dashboard JSON representation".
When "sourcing" a JSON, we show a toast saying "Dashboard loaded successfully". Should we use "load" instead of "source"?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
^ agree with Leo that "dashboard JSON" makes sense.
I also prefer load over source.
.Import dashboard dialog | ||
image::dashboards/import/import-dashboard-dialog.png[] | ||
|
||
Note that you only have the option to select a stored dashboard specification when there are stored dashboards in your database. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can this note and the next paragraph be boxed in?
|
||
If the dashboard specification selected for the import is syntactically correct, the **Import dashboard** dialog displays a **Summary** and **Details** for the import. | ||
This means that the import can be run. | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lets remember to remove this note in a couple of weeks
This means that the import can be run. | ||
|
||
|
||
== Supported types |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
call out that advanced types (via extension) are not supported
|=== | ||
|
||
|
||
== Summary |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can this be a list? or something more concise? it feels like a lot to digest
Entries include the location of the incident in the JSON specification, that is, the specific page and report, as well as a description what went wrong or is of note. | ||
|
||
|
||
== Example |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i'm not sure how i feel about having an (non-ideal migration) example in the docs.
Should we just skip it? I know we discussed otherwise, but I don't see the added value if we can make the details section easier to comprehend
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
removed the example, and added a list to the details section. we should probably add some entries to this list
== Creating a dashboard | ||
|
||
If you have no dashboards, select either **Create from scratch** or **Create with AI**. | ||
If you have no dashboards, select **Create dashboard** and either **Create from scratch** or **Import**. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this UI will change: https://linear.app/neo4j/issue/DASH-337/improve-quality-of-empty-states
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
when will it be available? asking because i think i need to retake some screenshots :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it's planned for this DevCycle, so probably in the next 2-3 weeks.
image::dashboards/create-first-dashboard.png[] | ||
|
||
If you want to create another dashboard: use **Create Dashboard** at the top right, and select either **Create from scratch** or **Create with AI**. | ||
If you already have a dashboard and want to create another, use **Create Dashboard** at the top right, and select **Create from scratch**, **Import** or **Create with AI**. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same here, UI will change
In the **Import dashboard** dialog, you have several options to source the dashboard specification for the import: | ||
|
||
* Browse for a JSON file on your machine. | ||
* Select a dashboard specification that is stored in your database. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
^ agree with Leo that "dashboard JSON" makes sense.
I also prefer load over source.
== Creating a dashboard | ||
|
||
If you have no dashboards, select either **Create from scratch** or **Create with AI**. | ||
If you have no dashboards, select **Create dashboard** and either **Create from scratch** or **Import**. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it's planned for this DevCycle, so probably in the next 2-3 weeks.
Thanks for the documentation updates. The preview documentation has now been torn down - reopening this PR will republish it. |
No description provided.