Skip to content

Make spatial query procedures read only #403

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

Andy2003
Copy link
Collaborator

@Andy2003 Andy2003 commented May 29, 2024

This PR changes the following procedure to be read-only:

  • spatial.layers
  • spatial.bbox
  • spatial.closest
  • spatial.withinDistance
  • spatial.intersects

@Andy2003 Andy2003 requested a review from jexp May 29, 2024 16:40
@Andy2003 Andy2003 force-pushed the feature/make-spatial-query-procedures-read-only branch from d730ddd to 083dafe Compare May 30, 2024 11:27
Copy link
Contributor

@craigtaverner craigtaverner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice fix. I do wonder if we should think of a better word than close for the method that flushes the count to the index?

@Andy2003 Andy2003 force-pushed the feature/make-spatial-query-procedures-read-only branch from 083dafe to 0be5527 Compare May 31, 2024 14:45
@Andy2003 Andy2003 force-pushed the master branch 5 times, most recently from 6844765 to bee28a4 Compare June 20, 2024 15:01
@Andy2003 Andy2003 force-pushed the feature/make-spatial-query-procedures-read-only branch from 0be5527 to 713c221 Compare February 18, 2025 13:47
@Andy2003 Andy2003 merged commit 0ad6edd into neo4j-contrib:master Feb 18, 2025
1 check passed
@Andy2003 Andy2003 deleted the feature/make-spatial-query-procedures-read-only branch February 18, 2025 14:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants