Support unicode identifiers #35 #2
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It would be preferable to rewrite the giant regex in a better documented form. Closes tenderlove#35.
This mimics the approach taken in WHITESPACE_REGEX, except that we simply fall back on the old regex if string doesn't respond to encoding?.
Since my earlier attempt accidentally created a regression with these.
tokenrove
force-pushed
the
support-unicode-identifiers-#35
branch
from
7867b8f to
1b7f8c7
Compare
GaetanJuvin
added a commit
to GaetanJuvin/rkelly-remix
that referenced
this pull request
Mar 24, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an attempt to fix issue tenderlove#35. Please let me know if there are improvements I should make.
This change is