Migration to git actions

.github/workflows/build_images.yml

@@ -0,0 +1,42 @@
+on: [push]
+jobs:
+  cancel:
+    runs-on: ubuntu-latest
+    name: Cancel Previous Runs
+    if: always()
+    steps:
+      - uses: styfle/cancel-workflow-action@d57d93c3a8110b00c3a2c0b64b8516013c9fd4c9
+        if: github.ref != 'refs/heads/master'
+        name: cancel old workflows
+        id: cancel
+        with:
+          workflow_id: "build_images.yml"
+          access_token: ${{ github.token }}
+      - if: github.ref == 'refs/heads/master'
+        name: Don't cancel old workflows
+        id: dont_cancel
+        run: |
+          echo "Don't cancel old workflow"
+  build-web:
+    name: Extension Build
+    runs-on: ubuntu-latest
+    needs: [cancel]
+    continue-on-error: false
+    steps:
+      - name: Checkout repo
+        uses: actions/checkout@v2
+      - name: Login to Dockerhub
+        uses: docker/login-action@v1
+        with:
+          username: ${{ secrets.PUBLIC_DOCKER_USERNAME }}
+          password: ${{ secrets.PUBLIC_DOCKER_PASSWORD }}
+      - name: Push To Dockerhub
+        uses: docker/build-push-action@v1
+        with:
+          username: ${{ secrets.PUBLIC_DOCKER_USERNAME }}
+          password: ${{ secrets.PUBLIC_DOCKER_PASSWORD }}
+          repository: ${{ github.repository }}
+          tags: ${{ github.sha }}
+          dockerfile: Dockerfile.rzp
+          build_args: GIT_COMMIT_HASH=${{ github.sha }},GIT_TOKEN=${{ secrets.GIT_ACTION_TOKEN }},GIT_USERNAME=rzp
+

.github/workflows/ci.yml

@@ -0,0 +1,160 @@
+name: CI
+on: [ push ]
+
+jobs:
+  build:
+    strategy:
+      fail-fast: false
+      matrix:
+        php: [ 7.0, 7.1, 7.2, 7.3, 7.4 ]
+
+    runs-on: ubuntu-latest
+
+    env:
+      TEST_PHP_ARGS: -q
+      REPORT_EXIT_STATUS: 1
+      RUN_EXTENSION_TESTS: 1
+      SUDO_CMD: "sudo"
+
+    steps:
+      - uses: actions/checkout@v2
+
+      - name: Set up PHP
+        uses: shivammathur/setup-php@v2
+        with:
+          php-version: "${{ matrix.php }}"
+
+      - name: Install build tools
+        run: |
+          autoconf -V || \
+            (
+              $SUDO_CMD apt-get update -y && \
+              $SUDO_CMD apt-get install -y -q --no-install-recommends \
+                build-essential \
+                g++ \
+                gcc \
+                libc-dev \
+                make \
+                autoconf \
+                git \
+                unzip
+            )
+
+      - name: Extension unit tests
+        run: |
+          if [ $RUN_EXTENSION_TESTS -eq "1" ]; then
+            pushd ext
+            phpize
+            ./configure --enable-opencensus
+            make test || ((find . -name '*.diff' | xargs cat) && false)
+            $SUDO_CMD make install
+            popd
+          else
+            echo "Skipping extension tests"
+          fi
+
+      - name: Cache Dependency
+        uses: actions/cache@v2
+        with:
+          path: ./vendor
+          key: v3-dependencies-${{ matrix.php }}-${{ hashFiles('composer.json') }}
+
+      - name: Install composer packages
+        run: composer install -n --prefer-dist
+
+      - name: Enable E_ALL error reporting for strict testing
+        run: $SUDO_CMD cp config/php.ini /usr/local/etc/php
+
+      - name: PHP Code Style
+        run: vendor/bin/phpcs --standard=./phpcs.xml
+
+      - name: PHP unit tests
+        run: vendor/bin/phpunit
+
+      - name: PHP unit tests with extension
+        run: |
+          if [ $RUN_EXTENSION_TESTS -eq "1" ]; then
+            php -d extension=opencensus.so vendor/bin/phpunit
+          else
+            echo "Skipping units tests with extension"
+          fi
+
+  integration:
+    runs-on: ubuntu-latest
+    env:
+      DB_HOST: 127.0.0.1
+      DB_USERNAME: mysql
+      DB_PASSWORD: mysql
+      DB_DATABASE: mysqldb
+      TEST_HOST: localhost
+      TEST_PORT: 9999
+      TEST_URL: http://localhost:9999
+
+    steps:
+      - uses: actions/checkout@v2
+
+      - name: Set up PHP
+        uses: shivammathur/setup-php@v2
+        with:
+          php-version: 7.2
+          extensions: memcached, pdo_mysql, mysqli, pdo_pgsql, pcntl
+          ini-values: extension=opencensus.so
+
+      - uses: niden/actions-memcached@v7
+
+      - name: Install opencensus extension
+        run: |
+          cd ext
+          phpize
+          ./configure --enable-opencensus
+          sudo make install
+
+      - name: Install memcached extension
+        run: |
+          sudo apt-get install -y -q --no-install-recommends \
+            libmemcached11 libmemcached-dev zlib1g-dev zlib1g
+
+      - name: Curl test
+        run: tests/integration/curl/test.sh
+
+      - name: Wordpress test
+        run: tests/integration/wordpress/test.sh
+
+      - name: Laravel test
+        run: tests/integration/laravel/test.sh
+
+      - name: Guzzle 5 test
+        run: tests/integration/guzzle5/test.sh
+
+      - name: Guzzle 6 test
+        run: tests/integration/guzzle6/test.sh
+
+      - name: Memcached test
+        run: tests/integration/memcached/test.sh
+
+      - name: Pgsql test
+        run: tests/integration/pgsql/test.sh
+
+      - name: Symfony 4 test
+        run: tests/integration/symfony4/test.sh
+        env:
+          DATABASE_URL: mysql://mysql:mysql@127.0.0.1:3306/mysqldb
+
+    services:
+      mysql:
+        image: mysql:5.7
+        ports:
+          - 3306:3306
+        env:
+          MYSQL_USER: mysql
+          MYSQL_PASSWORD: mysql
+          MYSQL_DATABASE: mysqldb
+          MYSQL_RANDOM_ROOT_PASSWORD: yes
+          MYSQL_ALLOW_EMPTY_PASSWORD: 1
+      postgres:
+        image: postgres:9.6
+        env:
+          POSTGRES_PASSWORD: pgsql
+          POSTGRES_USER: postgres
+        ports:
+          - 5432:5432

Dockerfile.rzp

@@ -0,0 +1,5 @@
+FROM razorpay/onggi:php-base
+
+COPY ext /ext
+
+RUN cd /ext && phpize && ./configure --enable-opencensus && make install

config/php.ini

@@ -1 +1 @@
-error_reporting = E_ALL
+error_reporting = E_ALL

ext/README.md

@@ -317,6 +317,26 @@ You can retrieve the version of this extension at runtime.
 function opencensus_trace_version();
 ```
 
+```php
+/**
+ * Retrieve the count of collected trace spans, currently in memory
+ *
+ * @return int
+ */
+function opencensus_trace_count();
+}
+```
+
+```php
+/**
+ * Removes a span from the list.
+ *
+ * @param string $key
+ *
+ */
+function opencensus_trace_remove_span($key);
+```
+
 This library follows [Semantic Versioning](http://semver.org/).
 
 Please note it is currently under active development. Any release versioned
@@ -342,3 +362,11 @@ See [CONTRIBUTING](../CONTRIBUTING.md) for more information on how to get starte
 ## License
 
 Apache 2.0 - See [LICENSE](LICENSE) for more information.
+
+## Exporting span once limit is reached to stop memory from bloating
+
+Have added $spanBufferLimit variable in ExtensionTracer.php to control the maximun number
+of spans that can be hold in memory at any time, when the limit is reached the tracer itself
+export all the closed spans.
+
+

ext/opencensus.c

@@ -54,6 +54,10 @@ ZEND_BEGIN_ARG_INFO_EX(arginfo_opencensus_trace_add_attribute, 0, 0, 2)
     ZEND_ARG_ARRAY_INFO(0, options, 0)
 ZEND_END_ARG_INFO()
 
+ZEND_BEGIN_ARG_INFO_EX(arginfo_opencensus_trace_remove_span, 0, 0, 1)
+    ZEND_ARG_TYPE_INFO(0, key, IS_STRING, 0)
+ZEND_END_ARG_INFO()
+
 ZEND_BEGIN_ARG_INFO_EX(arginfo_opencensus_trace_add_annotation, 0, 0, 1)
     ZEND_ARG_TYPE_INFO(0, description, IS_STRING, 0)
     ZEND_ARG_ARRAY_INFO(0, options, 0)
@@ -90,12 +94,14 @@ static zend_function_entry opencensus_functions[] = {
     PHP_FE(opencensus_trace_function, arginfo_opencensus_trace_function)
     PHP_FE(opencensus_trace_method, arginfo_opencensus_trace_method)
     PHP_FE(opencensus_trace_list, NULL)
+    PHP_FE(opencensus_trace_count, NULL)
     PHP_FE(opencensus_trace_begin, arginfo_opencensus_trace_begin)
     PHP_FE(opencensus_trace_finish, NULL)
     PHP_FE(opencensus_trace_clear, NULL)
     PHP_FE(opencensus_trace_set_context, arginfo_opencensus_trace_set_context)
     PHP_FE(opencensus_trace_context, NULL)
     PHP_FE(opencensus_trace_add_attribute, arginfo_opencensus_trace_add_attribute)
+    PHP_FE(opencensus_trace_remove_span, arginfo_opencensus_trace_remove_span)
     PHP_FE(opencensus_trace_add_annotation, arginfo_opencensus_trace_add_annotation)
     PHP_FE(opencensus_trace_add_link, arginfo_opencensus_trace_add_link)
     PHP_FE(opencensus_trace_add_message_event, arginfo_opencensus_trace_add_message_event)