Update gem to work on Solidus main branch #3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ikraamg
changed the title
ikraamg
force-pushed
the
update-gem-rails8-and-main
branch
from
cfccb9f to
fbd3eae
Compare
ikraamg
changed the title
ikraamg
force-pushed
the
update-gem-rails8-and-main
branch
8 times, most recently
from
41677ab to
b4e0e0f
Compare
See: solidusio/solidus@00465da And: solidusio/solidus@470b90a Acts_as_tenant adds a validation on belongs_to associations that trigger errors due to the product and payment method models not having a delegated association associated. This is because Solidus has some reader methods overriden to return the association object's value when the current model returns nil for the overriden method.
- This also updated the gem extention name so this commit does renaming as well
It conflicts with devise so it is not a good default without using the Nebulab fork
This fixes a bug when the development env reloader activates and loses the overrides added by `setup_tenant_aware_models`
ikraamg
force-pushed
the
update-gem-rails8-and-main
branch
6 times, most recently
from
4cdf1f7 to
706c16c
Compare
|
@DanielePalombo This is ready now. Thank you for the help! |
ikraamg
force-pushed
the
update-gem-rails8-and-main
branch
from
706c16c to
d1ba98b
Compare
DanielePalombo
approved these changes
Mar 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
to_preparewhen initializing the overrides to support development reloading.