[pull] main from solidusio:main #421
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![pull[bot]](https://avatars.githubusercontent.com/in/12910?s=80&v=4){kind=small}
To support the in-memory order updater, we want adjustments to be modified without writing to the database immediately. We added `autosave: true` in the association on line_items ensures that the adjustment amount will be saved with the line_item, or by extension the order when it is eventually persisted by the order updater. The tests for the OrderTaxation have been updated to use `size` instead of `count` to ensure an in-memory reported count/size. Co-authored-by: Adam Mueller <adam@super.gd> Co-authored-by: Andrew Stewart <andrew@super.gd> Co-authored-by: Jared Norman <jared@super.gd> Co-authored-by: Noah Silvera <noah@super.gd> Co-authored-by: benjamin wil <benjamin@super.gd> Co-authored-by: Alistair Norman <alistair@super.gd>
Instead of actually destroying adjustments in the OrderTaxation class, we can just mark them for removal. This will allow them to be removed when the order is persisted, instead of being removed during the recalculate process. This is an improvement in service of recalculating order changes without writing to the database. We also need to ensure `Order#adjustments` association has autosave enabled so that the marked for destruction adjustments are removed when we persist the order. We're also improving our OrderUpdater tests to better verify our changes maintain the existing behaviour. Co-authored-by: Adam Mueller <adam@super.gd> Co-authored-by: Alistair Norman <alistair@super.gd> Co-authored-by: Chris Todorov <chris@super.gd> Co-authored-by: Harmony Bouvier <harmony@super.gd> Co-authored-by: Kendra Riga <kendra@super.gd> Co-authored-by: Senem Soy <senem@super.gd> Co-authored-by: Sofia Besenski <sofia@super.gd> Co-authored-by: benjamin wil <benjamin@super.gd>
…ent-persistence-in-tax-calculations Avoid unnecessary adjustment persistence in tax calculations
This code has been automatically generated by our 'Prepare release' GitHub action. The actual release is not part of the automation, and it still needs to be manually done by a maintainer.
…1757405163 Prepare release for Solidus v4.6.0
This code has been automatically generated by our 'Prepare post-release' GitHub action. Make sure that: - [ ] The new release has been published, along with its tag. See https://github.com/solidusio/solidus/releases/tag/v4.6.0 - [ ] The corresponding patch branch exists. See https://github.com/solidusio/solidus/tree/v4.6 - [ ] The corresponding backport-v4.6 label exists. See https://github.com/solidusio/solidus/labels
…1757405652 Post-release chores after having released Solidus v4.6.0
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot] (v2.0.0-alpha.3)
Can you help keep this open source service alive? 💖 Please sponsor : )