[pull] main from solidusio:main #420
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![pull[bot]](https://avatars.githubusercontent.com/in/12910?s=80&v=4){kind=small}
When splitting backordered inventory units, we were incorrectly sending all backordered units to the desired shipment, regardless of the quantity chosen. Our original work on this changed from computing on_hand units first to the backordered ones. Unfortunately, we missed that we should only ever move as many as was requested, not all of the possible backordered ones.
When cancelling all items in a completed order, if the shipment is not already shipped, it should be marked as cancelled. However, if the shipment has already shipped, we should maintain its state because we treat that state as immutable.
At least, in terms of the state. We shouldn't mark shipped shipments as cancelled even if all of the items in the shipment get cancelled. If a shipment has been marked as shipped, then we need to preserve that state.
…tion Fix shipment state calculation
…tting Fix issue with splitting backordered units
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot] (v2.0.0-alpha.3)
Can you help keep this open source service alive? 💖 Please sponsor : )