[WIP] Refactor shipping_manifest on Spree::Shipment and Spree::Carton #20
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DanielePalombo
changed the title
`manifest` method returns Spree::ShippingManifest#items, this commit is going to rename it to `shipping_manifest_items`. I also refactored it to use the memoize shipping_manifest method.
`manifest` method returns Spree::ShippingManifest#items, this commit is going to rename it to `shipping_manifest_items`. I also refactored it to use the memoize shipping_manifest method.
This commit is going to rename the method `manifest_for_order` to `shipping_manifest_for_order` I also refactored it to use the memoized `shipping_manifest` method.
DanielePalombo
force-pushed
the
nebulab/add-shipping-manifest-to-shipment
branch
from
43cb51f to
e43dd87
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is going to rename the
manifestmethods on Spree::Shipment and Spree::Carton, because they return Spree::ShippingManifest#items .I added a new
shipping_manifestprivate method to memoize the ShippingManifest and reuse it in shipping_manifest_for_order.Both the methods
manifestandmanifest_for_orderare deprecated.