Add support for treating Metafield/Metaobject definitions as a database schema #2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
elia
changed the title
elia
force-pushed
the
elia/migrations
branch
2 times, most recently
from
ecb7dbb to
f80fd7e
Compare
elia
force-pushed
the
elia/migrations
branch
2 times, most recently
from
a0fd1ac to
a7a1e16
Compare
Detach from database migrations. This solves a number of problems where a dev db was reset while the dev shopify app already had its metafields defined. Also using ShopifyApp the app token is stored within the db itself, putting the migrations in a deadlock if run from an empty db. Co-Authored-By: Alberto Vena <kennyadsl@gmail.com> Co-Authored-By: Marco Arduini <mar.arduini@gmail.com> Co-Authored-By: Gianluca Elia <34285663+gianlukk994@users.noreply.github.com> Co-Authored-By: Nicolò Rebughini <nicolo.rebughini@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request introduces a migration framework for the Shopify Toolkit, enabling the management of migrations through a set of commands and supporting classes. The key changes include adding command-line tasks for migrations, implementing a
Migrationbase class, and creating aMigratorclass to handle migration execution and metadata management.Command-line enhancements:
migrate,down,redo) to run migrations up, down, or redo them, utilizing theShopifyToolkit::Migratorclass. (lib/shopify_toolkit/command_line.rb, lib/shopify_toolkit/command_line.rbR56-R73)Migration framework:
ShopifyToolkit::Migrationbase class with methods for definingupanddownmigrations, logging, and handling migration directions. (lib/shopify_toolkit/migration.rb, lib/shopify_toolkit/migration.rbR1-R63)IrreversibleMigrationexception. (lib/shopify_toolkit/migration.rb, lib/shopify_toolkit/migration.rbR1-R63)Migration execution and metadata management:
ShopifyToolkit::Migratorclass to load, execute, and manage migrations, including metafield-based storage of migrated versions for tracking state. (lib/shopify_toolkit/migrator.rb, lib/shopify_toolkit/migrator.rbR1-R152)MigrationProxyto defer loading of migration classes until needed, improving efficiency and modularity. (lib/shopify_toolkit/migrator.rb, lib/shopify_toolkit/migrator.rbR1-R152)