Improve the command line #12
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request refactors the
ShopifyToolkit::CommandLineclass by moving its implementation from theexe/shopify-toolkitfile into a new dedicated file,lib/shopify_toolkit/command_line.rb. This change improves the organization and maintainability of the codebase. Additionally, a new methodexit_on_failure?has been introduced to ensure proper exit behavior for the CLI.Code organization and refactoring:
ShopifyToolkit::CommandLinehas been moved fromexe/shopify-toolkitto a new file,lib/shopify_toolkit/command_line.rb, aligning with standard Ruby project structure. [1] [2]New functionality:
exit_on_failure?method to theShopifyToolkit::CommandLineclass, ensuring the CLI exits with a non-zero status code on failure.