Reintegrate upstream #74
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It's a bit much for Tailwind CSS projects.
Currently, unquoted and name-only attributes are placed on a new line,
even when they could fit on the same line. This PR modifies this
behavior to keep them on the same line when possible.
Expected output:
<input type="hidden" name="my-name" value="my-value" hidden/>
Current output:
<input type="hidden" name="my-name" value="my-value"
hidden/>
CSS classes cannot begin with digits. For this reason, Tailwind uses
`\3` to escape them. For instance, `2xl:col-span-10` is transformed into
`.\32xl\:col-span-10 { grid-column: span 10 / span 10; }` in the final
CSS file.
tailwindlabs/tailwindcss#3069
The current Tailwind CSS class sorter implementation does not handle
this correctly. As it cannot identify suitable classes beginning with
digits, it places them at the start of the sorted list.
Expected output:
divide-y divide-gray-200 lg:col-span-8 xl:col-span-9 2xl:col-span-10 pb-10
Current output:
2xl:col-span-10 divide-y divide-gray-200 pb-10 lg:col-span-8 xl:col-span-9
I simply remove the escape characters from the class name.
`erb-formatter` uses the `syntax_tree` gem which has its own
formatting ideas about ruby, but, in our code base, so does Rubocop,
the latter which we configure extensively. When they disagree, the
result is flip-flopping between tools, and that can fail the clover
build, in this CI step in `.github/workflows/ci.yml`:
- name: Check that source code formatters and annotations make no changes
run: git diff --stat --exit-code
This was motivated by an attempt to this `.rubocop.yml` configuration
in clover:
Layout/DotPosition:
EnforcedStyle: trailing
In this case, Rubocop moves method-chained periods to the ends of
lines, and then `erb-formatter` moves them back to the beginning
again. This fails CI.
Given our more extensive rubocop use, and use of the `rubocop-erb` as
we also use it for rewriting, it's simpler to remove `syntax_tree` as
a dependency altogether, and not attempt to format code in
`erb-formatter`. This keeps `erb-formatter` the rest of its
functionality, such as tag indentation.
fdr
force-pushed
the
reintegrate-upstream
branch
from
177852d to
df31744
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.