Skip to content

Put unquoted and name only attributes on the same line when possible #59

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Put unquoted and name only attributes on the same line when possible #59

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions lib/erb/formatter.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -141,12 +141,12 @@ def format_attributes(tag_name, attrs, tag_closing)
name, value = attr.split('=', 2)

if value.nil?
attr_html << indented("#{name}")
attr_html << (within_line_width ? " #{name}" : indented("#{name}"))
next
end

if /\A#{UNQUOTED_VALUE}\z/o.match?(value)
attr_html << indented("#{name}=\"#{value}\"")
attr_html << (within_line_width ? " #{name}=\"#{value}\"" : indented("#{name}=\"#{value}\""))
next
end

Expand Down
2 changes: 2 additions & 0 deletions test/fixtures/attributes.html.erb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,3 +9,5 @@
data-short-url="//test.com/?q=v"
data-long-url="https://google.ca/this-is-a-long-url-with-a-query-string?query=something"
data-long-url-single='https://google.ca/this-is-a-long-url-with-a-query-string?query=something'>
<input type=text class="text-sm" hidden />
<input name="very-long-name-should-break-because-of-longer-than-width" type=text class="text-sm" hidden />
7 changes: 7 additions & 0 deletions test/fixtures/attributes.html.expected.erb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,3 +8,10 @@
data-long-url="https://google.ca/this-is-a-long-url-with-a-query-string?query=something"
data-long-url-single='https://google.ca/this-is-a-long-url-with-a-query-string?query=something'
>
<input type="text" class="text-sm" hidden/>
<input
name="very-long-name-should-break-because-of-longer-than-width"
type="text"
class="text-sm"
hidden
/>