Fix order of classes starting with digits in tailwindcss class sorter #58
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CSS classes cannot begin with digits. For this reason, Tailwind uses
`\3` to escape them. For instance, `2xl:col-span-10` is transformed into
`.\32xl\:col-span-10 { grid-column: span 10 / span 10; }` in the final
CSS file.
tailwindlabs/tailwindcss#3069
The current Tailwind CSS class sorter implementation does not handle
this correctly. As it cannot identify suitable classes beginning with
digits, it places them at the start of the sorted list.
Expected output:
divide-y divide-gray-200 lg:col-span-8 xl:col-span-9 2xl:col-span-10 pb-10
Current output:
2xl:col-span-10 divide-y divide-gray-200 pb-10 lg:col-span-8 xl:col-span-9
I simply remove the escape characters from the class name.
|
Hi @elia, do you have any reviews for this PR? |
1 similar comment
|
Hi @elia, do you have any reviews for this PR? |
enescakir
added a commit
to ubicloud/ubicloud
that referenced
this pull request
Nov 7, 2024
We were using a forked version of nebula/erb-formatter due to these two commits: - ubicloud/erb-formatter@05b30f6 - ubicloud/erb-formatter@a9ff000 These issues have been fixed upstream, so I initially planned to switch to the official package. However, I encountered another problem and created two PRs to address them. Unfortunately, I didn't receive any response from the maintainer. Thus, I've decided to continue using our updated forked version. - nebulab/erb-formatter#58 - nebulab/erb-formatter#59
enescakir
added a commit
to ubicloud/ubicloud
that referenced
this pull request
Nov 7, 2024
We were using a forked version of nebula/erb-formatter due to these two commits: - ubicloud/erb-formatter@05b30f6 - ubicloud/erb-formatter@a9ff000 These issues have been fixed upstream, so I initially planned to switch to the official package. However, I encountered another problem and created two PRs to address them. Unfortunately, I didn't receive any response from the maintainer. Thus, I've decided to continue using our updated forked version. - nebulab/erb-formatter#58 - nebulab/erb-formatter#59
There was a problem hiding this comment.
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
Comments suppressed due to low confidence (1)
lib/erb/formatter/command_line.rb:12
- Ensure that the sequential gsub calls correctly handle all variants of escaped digit prefixes. Consider combining them into a single regex for clarity and to avoid potential mismatches in edge cases.
classes = css.tr(","," ").split(" ").grep(/\./).uniq.map { _1.split('.').last.gsub("\3", "").gsub("\", "") }
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CSS classes cannot begin with digits. For this reason, Tailwind uses
\3to escape them. For instance,2xl:col-span-10is transformed into.\32xl\:col-span-10 { grid-column: span 10 / span 10; }in the final CSS file.tailwindlabs/tailwindcss#3069
The current Tailwind CSS class sorter implementation does not handle this correctly. As it cannot identify suitable classes beginning with digits, it places them at the start of the sorted list.
Expected output:
Current output:
I simply remove the escape characters from the class name.