feat: refactor biometric attendance API with employee ID mapping and code cleanup #15
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
tuwafula
commented
Sep 2, 2025
tuwafula
commented
- Fix employee lookup to use device ID mapping instead of raw UserID
- Add proper error handling for unknown device IDs in punch logs
- Standardize code formatting and remove duplicates
…ling - handle_punch_logs: - Return early when no logs - Batch-resolve Employees by attendance_device_id and map to names - Use Employee name for Employee Checkin records - General formatting and comment cleanup
- Add proper employee lookup by attendance_device_id - Implement error logging for missing employees and unknown device IDs - Fix employee reference in checkin creation - Add validation to skip invalid punch log entries
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.